Adar Dembo has posted comments on this change. Change subject: [WIP]log block manager:mark container as 'non-writable' after IOError ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/7374/7/src/kudu/fs/block_manager-test.cc File src/kudu/fs/block_manager-test.cc: Line 968: TYPED_TEST(BlockManagerTest, TestMetadataOkayDespiteFailedClose) { > I made it a separate test to explicitly test with fault injection around bl How about: 1) Write a targeted test that issues a specific sequence of operations with fault injection toggled as needed, guaranteed to yield corrupt containers without your fix, or 2) Convert TestMetadataOkayDespiteFailedWrites into a function and parameterize it sufficiently so that the existing test and this new one can make use of it by simply calling the function with different parameter values. http://gerrit.cloudera.org:8080/#/c/7374/7/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: PS7, Line 470: but write block : // and delete block are. > Typo.. it should be read operation... If we forbid delete operation that m Correct, at least not until the next restart. The tablet's superblock contains a list of blocks to be deleted at startup and IIRC they are only removed from that list when deletion is actually successful. If they somehow make it off that list despite deletion failing, they'll qualify as true orphaned blocks and will be deleted by the next "kudu fs check --repair". -- To view, visit http://gerrit.cloudera.org:8080/7374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15062b9d82c9cb563fb6bb2af7ec89da5f71e28f Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
