Dan Burkert has posted comments on this change.

Change subject: Hive MetaStore client, HMS Plugin
......................................................................


Patch Set 16:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/7053/12/src/kudu/hms/hms_client-test.cc
File src/kudu/hms/hms_client-test.cc:

PS12, Line 67: ASSERT_OK(client.GetDatabase(dat
> nit here and below: may be, output the whole info on those objects only if 
Done


http://gerrit.cloudera.org:8080/#/c/7053/16/src/kudu/hms/hms_client-test.cc
File src/kudu/hms/hms_client-test.cc:

Line 32: #include "kudu/hms/hive_metastore_constants.h"
> warning: #includes are not sorted properly [llvm-include-order]
Done


http://gerrit.cloudera.org:8080/#/c/7053/12/src/kudu/hms/hms_client.cc
File src/kudu/hms/hms_client.cc:

PS12, Line 49: // as a catch all, as well as default for network errors.
             : #define HMS_RET_NOT_OK(call, msg) \
             :   try { \
             :     (call); \
> nit: not very important here, but anyway it might make sense to add parenth
Done


http://gerrit.cloudera.org:8080/#/c/7053/16/src/kudu/hms/hms_client.cc
File src/kudu/hms/hms_client.cc:

Line 31: #include "kudu/hms/hive_metastore_constants.h"
> warning: #includes are not sorted properly [llvm-include-order]
Done


http://gerrit.cloudera.org:8080/#/c/7053/12/src/kudu/hms/mini_hms.h
File src/kudu/hms/mini_hms.h:

PS12, Line 38: NotificationLogTtl(Mono
> nit: the std::unique_ptr has specific operator
Done


http://gerrit.cloudera.org:8080/#/c/7053/16/src/kudu/hms/mini_hms.h
File src/kudu/hms/mini_hms.h:

Line 55:   Status CreateHiveSite(const std::string& dir) const 
WARN_UNUSED_RESULT;
> warning: function 'kudu::MiniHms::CreateHiveSite' has a definition with dif
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I155223da912bc18a759df2f1f6bc25d1132a99ee
Gerrit-PatchSet: 16
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to