Alexey Serbin has posted comments on this change. Change subject: Add basic Hive MetaStore client ......................................................................
Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/7053/10/cmake_modules/FindJavaHome.cmake File cmake_modules/FindJavaHome.cmake: PS10, Line 55: /Library/Java/Home Just FYI: at my laptop JDK is in /Library/Java/JavaVirtualMachines/jdk1.8.0_102.jdk so JAVA_HOME seems to be /Library/Java/JavaVirtualMachines/jdk1.8.0_102.jdk/Contents/Home http://gerrit.cloudera.org:8080/#/c/7053/10/src/kudu/hms/hms_client.cc File src/kudu/hms/hms_client.cc: PS10, Line 60: } Does it make sense to add catch-all as well? http://gerrit.cloudera.org:8080/#/c/7053/10/src/kudu/hms/hms_client.h File src/kudu/hms/hms_client.h: PS10, Line 50: ; Consider adding WARN_UNUSED_RESULT http://gerrit.cloudera.org:8080/#/c/7053/10/src/kudu/hms/mini_hms.h File src/kudu/hms/mini_hms.h: PS10, Line 40: const ? -- To view, visit http://gerrit.cloudera.org:8080/7053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I155223da912bc18a759df2f1f6bc25d1132a99ee Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
