Dan Burkert has posted comments on this change. Change subject: Add basic Hive MetaStore client ......................................................................
Patch Set 10: (8 comments) http://gerrit.cloudera.org:8080/#/c/7053/10/cmake_modules/FindJavaHome.cmake File cmake_modules/FindJavaHome.cmake: PS10, Line 55: /Library/Java/Home > Just FYI: at my laptop JDK is in /Library/Java/JavaVirtualMachines/jdk1.8.0 I've changed this to use /usr/libexec/java_home on OS X, which should always give the correct answer. http://gerrit.cloudera.org:8080/#/c/7053/10/src/kudu/hms/CMakeLists.txt File src/kudu/hms/CMakeLists.txt: PS10, Line 47: COMMAND ln -sf : "${JAVA_HOME}" : "${EXECUTABLE_OUTPUT_PATH}/java-home" > As I understand, ${JAVA_HOME} is a directory. What happens if this command Done http://gerrit.cloudera.org:8080/#/c/7053/10/src/kudu/hms/hms_client.cc File src/kudu/hms/hms_client.cc: PS10, Line 60: } > Does it make sense to add catch-all as well? The TException acts as a catchall (in addition to handling network errors). http://gerrit.cloudera.org:8080/#/c/7053/10/src/kudu/hms/hms_client.h File src/kudu/hms/hms_client.h: PS10, Line 50: ; > Consider adding WARN_UNUSED_RESULT Done http://gerrit.cloudera.org:8080/#/c/7053/10/src/kudu/hms/mini_hms.cc File src/kudu/hms/mini_hms.cc: PS10, Line 26: #include <gflags/gflags.h> > Is it needed in here? Done PS10, Line 49: SIGKILL > Why not SIGTERM? Done http://gerrit.cloudera.org:8080/#/c/7053/10/src/kudu/hms/mini_hms.h File src/kudu/hms/mini_hms.h: PS10, Line 40: > const ? Done http://gerrit.cloudera.org:8080/#/c/7053/10/src/kudu/util/test_util.h File src/kudu/util/test_util.h: PS10, Line 112: // Attempts to find the path to the executable, searching the provided locations : // as well as the $PATH environment variable. : Status GetExecutablePath(const std::string& binary, : const std::vector<std::string>& search, : std::string* path) WARN_UNUSED_RESULT; : : // Waits for the subprocess to bind to any listening TCP port, and returns the port. : Status WaitForTcpBind(pid_t pid, uint16_t* port, MonoDelta timeout) WARN_UNUSED_RESULT; : : // Waits for the subprocess to bind to any listening UDP port, and returns the port. : Status WaitForUdpBind(pid_t pid, uint16_t* port, MonoDelta timeout) WARN_UNUSED_RESULT; > Maybe, it's worth publishing it ((.e. moving those things from kerberos-sp Good idea. -- To view, visit http://gerrit.cloudera.org:8080/7053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I155223da912bc18a759df2f1f6bc25d1132a99ee Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
