Todd Lipcon has posted comments on this change.
Change subject: WIP: [iwyu] first pass
......................................................................
Patch Set 14:
definitely woudl be nice to get rid of some of the more common pragmas...
here's a count from grep | uniq -c | sort -nk1
10 #include <boost/optional/optional_fwd.hpp> // IWYU pragma: keep
15 // IWYU pragma: no_include <gflags/gflags_declare.h>
16 // IWYU pragma: no_include <ext/alloc_traits.h>
26 #include <boost/bind.hpp> // IWYU pragma: keep
27 // IWYU pragma: no_include <ostream>
32 // IWYU pragma: no_include "kudu/util/logging.h"
37 #include <glog/logging.h> // IWYU pragma: keep
These are all from IWYU bugs? Are they known bugs? If we are going to expect
people to keep IWYU clean at precommit I wish it were a bit less error-prone,
otherwise the extra time spent on trying to make it happy will outweigh any
extra time saved with faster builds, no?
Or is the plan to just periodically (eg once a month) run this and fix any
errors it comes up with, and hopefully those incremental fixes will be smaller
than this initial patch?
--
To view, visit http://gerrit.cloudera.org:8080/4738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6923091be36a1c03fac34dd73e6b17e17ac9ceaa
Gerrit-PatchSet: 14
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: No
