Attila Bukor has posted comments on this change. Change subject: [java] KUDU-2103 Canonicalize hostnames in client ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7757/1/java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java File java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java: Line 74: public String getHostname() { > I think it's bad form to hide a potentially-expensive DNS request in what l makes sense. what if I change the method's name to getCanonicalHostname() or add a new method called that? that should imply there's a hostname resolution happening and this looks like an internal API so a change like that shouldn't break anything. Or should I just put it in Connection? -- To view, visit http://gerrit.cloudera.org:8080/7757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77204a185c1ab8e21cc833afb645543cbc0e340f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
