Attila Bukor has posted comments on this change. Change subject: [java] KUDU-2103 Canonicalize hostnames in client ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7757/3/java/kudu-client/src/test/java/org/apache/kudu/client/FakeDNS.java File java/kudu-client/src/test/java/org/apache/kudu/client/FakeDNS.java: PS3, Line 93: if (forwardResolutions.containsKey(host)) { : return new InetAddress[]{forwardResolutions.get(host)}; : } > nit: to avoid double lookup, restructure as: shouldn't run an actual lookup, but changed it http://gerrit.cloudera.org:8080/#/c/7757/4/java/kudu-client/src/test/java/org/apache/kudu/client/FakeDNS.java File java/kudu-client/src/test/java/org/apache/kudu/client/FakeDNS.java: PS4, Line 56: } : : public Map<InetAddress, String> getReverseResolutions() { : return reverseResolutions; : } : : / > sorry, one more nit I missed: we always define all members up front before I did but unfortunately it's not configured to run on the tests directory, only on main. (Tried to post it to your last review, but only saved it as a draft... need to get used to this UI...) -- To view, visit http://gerrit.cloudera.org:8080/7757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77204a185c1ab8e21cc833afb645543cbc0e340f Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
