Todd Lipcon has posted comments on this change. Change subject: [java] KUDU-2103 Canonicalize hostnames in client ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7757/4/java/kudu-client/src/test/java/org/apache/kudu/client/FakeDNS.java File java/kudu-client/src/test/java/org/apache/kudu/client/FakeDNS.java: PS4, Line 56: public synchronized void addForwardResolution(String hostname, InetAddress ip) { : forwardResolutions.put(hostname, ip); : } : : public synchronized void addReverseResolution(InetAddress ip, String hostname) { : reverseResolutions.put(ip, hostname); : } sorry, one more nit I missed: we always define all members up front before any methods, so these below down below (probably below getInstance() for best organization) Did you see my note about checkstyle? I think it would probably flag this. -- To view, visit http://gerrit.cloudera.org:8080/7757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77204a185c1ab8e21cc833afb645543cbc0e340f Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
