Adar Dembo has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager ......................................................................
Patch Set 32: (1 comment) http://gerrit.cloudera.org:8080/#/c/7207/32/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: PS32, Line 1217: if (container_->read_only()) { : state_ = CLOSED; : if (container_->metrics()) { : container_->metrics()->generic_metrics.blocks_open_writing->Decrement(); : container_->metrics()->generic_metrics.total_bytes_written->IncrementBy( : block_length_); : } : return Status::Aborted("container $0 is read-only", container_->ToString()); : } > Do we need to check if state_ is already CLOSED and if so make this a no-op It's hard to tell whether it's possible to wind up calling Abort() twice on a read-only container given the constraints required to get a container to become read-only, but Mike's suggestion certainly won't hurt. -- To view, visit http://gerrit.cloudera.org:8080/7207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01f3ed830cc1f86d7bb8a66b2f780914a88884bd Gerrit-PatchSet: 32 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
