Adar Dembo has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager ......................................................................
Patch Set 32: (2 comments) http://gerrit.cloudera.org:8080/#/c/7207/32/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: Line 132 > Adar earlier made the point "it shouldn't be part of the WritableBlock inte There's no avoiding a downcast in LogBlockManager::CloseBlocks; we need it in order to call other non-interface methods on LogWritableBlock. But, if you prefer to reduce the number of downcasts from two to one, some light refactoring could do that. http://gerrit.cloudera.org:8080/#/c/7207/32/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: PS32, Line 1217: if (container_->read_only()) { : state_ = CLOSED; : if (container_->metrics()) { : container_->metrics()->generic_metrics.blocks_open_writing->Decrement(); : container_->metrics()->generic_metrics.total_bytes_written->IncrementBy( : block_length_); : } : return Status::Aborted("container $0 is read-only", container_->ToString()); : } > Makes sense. I don't see a case we would want to Abort() the block if it is I would prefer we didn't change API semantics at this point. Multiple Abort() calls in succession are legal; let's keep them that way (and ensure they no-op). -- To view, visit http://gerrit.cloudera.org:8080/7207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01f3ed830cc1f86d7bb8a66b2f780914a88884bd Gerrit-PatchSet: 32 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
