Adar Dembo has posted comments on this change. Change subject: [iwyu] fix on <ext/alloc_traits.h> ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7867/2/build-support/iwyu/iwyu-filter.awk File build-support/iwyu/iwyu-filter.awk: Line 32: # Usage: Any particular reason to explain all this now that there's iwyu.sh? We could just ask people to run that, no? http://gerrit.cloudera.org:8080/#/c/7867/2/build-support/iwyu/mappings/libstdcpp.imp File build-support/iwyu/mappings/libstdcpp.imp: Shouldn't this new file be referenced in iwyu.sh? PS2, Line 18: { include: ["<ext/alloc_traits.h>", private, "<memory>", public ] }, : { include: ["<ext/alloc_traits.h>", private, "<condition_variable>", public ] }, : { include: ["<ext/alloc_traits.h>", private, "<unordered_map>", public ] }, : { include: ["<ext/alloc_traits.h>", private, "<unordered_set>", public ] } Why all four recommendations? Why not just one, like <memory>? -- To view, visit http://gerrit.cloudera.org:8080/7867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
