Alexey Serbin has posted comments on this change. Change subject: [iwyu] fix on <ext/alloc_traits.h> ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7867/2/build-support/iwyu/iwyu-filter.awk File build-support/iwyu/iwyu-filter.awk: Line 32: # Usage: > Any particular reason to explain all this now that there's iwyu.sh? We coul The sequence described in this file is for the full IWYU run. Yes, it might be achieved via iwyu.sh as well, but iwyu.sh cannot invoke the tool in parallel, making it very slow (about 3 times slower than regular 'make -j1' run). I'm thinking to preserve this way of running full/non-incremental IWYU coverage. http://gerrit.cloudera.org:8080/#/c/7867/2/build-support/iwyu/mappings/libstdcpp.imp File build-support/iwyu/mappings/libstdcpp.imp: > Shouldn't this new file be referenced in iwyu.sh? yes -- it seems I missed that (i.e. I missed that change in this changelist), my bad -- will fix it. PS2, Line 18: { include: ["<ext/alloc_traits.h>", private, "<memory>", public ] }, : { include: ["<ext/alloc_traits.h>", private, "<condition_variable>", public ] }, : { include: ["<ext/alloc_traits.h>", private, "<unordered_map>", public ] }, : { include: ["<ext/alloc_traits.h>", private, "<unordered_set>", public ] } > Why all four recommendations? Why not just one, like <memory>? It might happen that the file already includes at least one of the rest: <condition_variable>, <unordered_map>, <unordered_set>. If so, then the <ext/alloc_traits.h> would be included transitively, and there is no need to include <memory>. As I understand, the idea is that IWYU recommends to include the very first of the listed alternatives (i.e. <memory>) if nothing else is included yet. If other alternative mapping is already applied, then IWYU would happily accept that. -- To view, visit http://gerrit.cloudera.org:8080/7867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
