Adar Dembo has posted comments on this change. Change subject: [iwyu] fix on <ext/alloc_traits.h> ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7867/2/build-support/iwyu/iwyu-filter.awk File build-support/iwyu/iwyu-filter.awk: Line 32: # Usage: > The sequence described in this file is for the full IWYU run. Yes, it migh Okay. http://gerrit.cloudera.org:8080/#/c/7867/2/build-support/iwyu/mappings/libstdcpp.imp File build-support/iwyu/mappings/libstdcpp.imp: PS2, Line 18: { include: ["<ext/alloc_traits.h>", private, "<memory>", public ] }, : { include: ["<ext/alloc_traits.h>", private, "<condition_variable>", public ] }, : { include: ["<ext/alloc_traits.h>", private, "<unordered_map>", public ] }, : { include: ["<ext/alloc_traits.h>", private, "<unordered_set>", public ] } > It might happen that the file already includes at least one of the rest: <c Makes sense. In gcc 5.4 <string> would also work (via basic_string.h). Or <map>/<set> (via stl_tree.h). Or <deque>/<vector> (via stl_construct.h): adar@adar-ThinkPad-T540p:/usr/include/c++/5$ grep -RI ext/alloc_traits.h bits/basic_string.h:#include <ext/alloc_traits.h> bits/forward_list.h:#include <ext/alloc_traits.h> bits/stl_tree.h:#include <ext/alloc_traits.h> bits/stl_construct.h:#include <ext/alloc_traits.h> ext/debug_allocator.h:#include <ext/alloc_traits.h> unordered_set:#include <ext/alloc_traits.h> unordered_map:#include <ext/alloc_traits.h> debug/safe_container.h:#include <ext/alloc_traits.h> adar@adar-ThinkPad-T540p:/usr/include/c++/5$ grep -RI basic_string.h string:#include <bits/basic_string.h> adar@adar-ThinkPad-T540p:/usr/include/c++/5$ grep -RI stl_tree.h ext/rb_tree:#include <bits/stl_tree.h> map:#include <bits/stl_tree.h> set:#include <bits/stl_tree.h> adar@adar-ThinkPad-T540p:/usr/include/c++/5$ grep -RI stl_construct.h bits/stl_tempbuf.h:#include <bits/stl_construct.h> ext/slist:#include <bits/stl_construct.h> ext/rope:#include <bits/stl_construct.h> deque:#include <bits/stl_construct.h> memory:#include <bits/stl_construct.h> vector:#include <bits/stl_construct.h> -- To view, visit http://gerrit.cloudera.org:8080/7867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
