Mike Percy has posted comments on this change. Change subject: KUDU-2131: switch to FILO log container retrieval ......................................................................
Patch Set 1: (1 comment) Thanks for changing the default tablet copy idle timeout. Adar is more familiar with the log block manager container selection code so I'll let him comment on that part. http://gerrit.cloudera.org:8080/#/c/7952/1/src/kudu/tserver/tablet_copy_service-test.cc File src/kudu/tserver/tablet_copy_service-test.cc: PS1, Line 492: FLAGS_tablet_copy_idle_timeout_sec = 1 / 1000 This is going to perform integer division and result in 0, so we should just set it to 0 and update the comment. -- To view, visit http://gerrit.cloudera.org:8080/7952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6eb0bc99422c293417b64e0b6e86c87a3d55e687 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
