Adar Dembo has posted comments on this change. Change subject: KUDU-2131: switch to FILO log container retrieval ......................................................................
Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/7952/1//COMMIT_MSG Commit Message: PS1, Line 7: FILO Nit: not that FILO isn't descriptive, but I think LIFO is more conventional to describe stack-like behavior. PS1, Line 12: for of PS1, Line 14: containers(only containers (only PS1, Line 15: default : idle timeout You should clarify that this is the default idle timeout for a tablet copy session. PS1, Line 21: amount number of fsync() operations PS1, Line 22: plenty plenty of PS1, Line 27: rename renames PS1, Line 26: to be : a as a http://gerrit.cloudera.org:8080/#/c/7952/1/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: Line 1380: // Test available log container selection is FILO. LIFO here too. Line 1397: // Thus, the first available container in the queue can be reused. "The first available container in the queue will be reused every time." PS1, Line 1405: finalize finalizing http://gerrit.cloudera.org:8080/#/c/7952/1/src/kudu/tserver/tablet_copy_service.cc File src/kudu/tserver/tablet_copy_service.cc: PS1, Line 101: FromMilliseconds Should be FromSeconds. -- To view, visit http://gerrit.cloudera.org:8080/7952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6eb0bc99422c293417b64e0b6e86c87a3d55e687 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
