Hao Hao has posted comments on this change. Change subject: KUDU-2131: switch to LIFO log container retrieval ......................................................................
Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/c/7952/1//COMMIT_MSG Commit Message: PS1, Line 7: LIFO > Nit: not that FILO isn't descriptive, but I think LIFO is more conventional Done PS1, Line 12: of > of Done PS1, Line 14: 14 disks and 19 > containers (only Done PS1, Line 15: t : DownloadBloc > You should clarify that this is the default idle timeout for a tablet copy Done PS1, Line 21: e. Thu > number of fsync() operations Done PS1, Line 22: ted bl > plenty of Done PS1, Line 27: ut act > renames Done PS1, Line 26: : t > as a Done http://gerrit.cloudera.org:8080/#/c/7952/1/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: Line 1380: // Test available log container selection is LIFO. > LIFO here too. Done Line 1397: // The first available container in the queue will be reused every time. > "The first available container in the queue will be reused every time." Done PS1, Line 1405: finalizi > finalizing Done http://gerrit.cloudera.org:8080/#/c/7952/1/src/kudu/tserver/tablet_copy_service-test.cc File src/kudu/tserver/tablet_copy_service-test.cc: PS1, Line 492: FLAGS_tablet_copy_idle_timeout_sec = 0; // Ex > This is going to perform integer division and result in 0, so we should jus Done http://gerrit.cloudera.org:8080/#/c/7952/1/src/kudu/tserver/tablet_copy_service.cc File src/kudu/tserver/tablet_copy_service.cc: PS1, Line 101: FromSeconds(FLAG > Should be FromSeconds. Done -- To view, visit http://gerrit.cloudera.org:8080/7952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6eb0bc99422c293417b64e0b6e86c87a3d55e687 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
