Alexey Serbin has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7967/1/src/kudu/cfile/encoding-test.cc File src/kudu/cfile/encoding-test.cc: PS1, Line 277: LOG(INFO) << "format string: " << format_string; nit: is it important to have this information to be output during the test even in case of success? If not, consider replaces this LOG(INFO) and LOG(INFO) at like 289 below with signle SCOPED_TRACE(strings::Substitute("format string: $0; block: $1", format_string, HexDump(s))); -- To view, visit http://gerrit.cloudera.org:8080/7967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic46d2a993235e560475d931c7b023eb5b4faf7c2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
