Todd Lipcon has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7967/1//COMMIT_MSG Commit Message: Line 16: The fix just replaces any '\0' characters in the random format string. > Does this also fix http://dist-test.cloudera.org:8080/diagnose?key=a32eeefe it does now (ensured that it now always adds at least one element to the block) http://gerrit.cloudera.org:8080/#/c/7967/1/src/kudu/cfile/encoding-test.cc File src/kudu/cfile/encoding-test.cc: PS1, Line 255: or '\0', but > Will brought this up when we were discussing this earlier and thought I'd b restructured this test substantially so now it tests random-length binary sequences including nulls PS1, Line 277: LOG(INFO) << "format string: " << format_string; > nit: is it important to have this information to be output during the test removed -- To view, visit http://gerrit.cloudera.org:8080/7967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic46d2a993235e560475d931c7b023eb5b4faf7c2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
