Todd Lipcon has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7967/2/src/kudu/cfile/encoding-test.cc File src/kudu/cfile/encoding-test.cc: PS2, Line 101: uint > Nit: GSG says use int for loop variable. Done PS2, Line 103: slices.emplace_back(to_insert[i]); > Why not slices.emplace_back(formatter(i))? Does to_insert have a purpose? yea, Slices are just non-owned pointers, so we have to keep the string objects alive somewhere or else the underlying memory gets freed. -- To view, visit http://gerrit.cloudera.org:8080/7967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic46d2a993235e560475d931c7b023eb5b4faf7c2 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
