Mike Percy has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/7961/3/src/kudu/integration-tests/tablet_copy-itest.cc File src/kudu/integration-tests/tablet_copy-itest.cc: PS3, Line 1155: ASSERT_EVENTUALLY > By default, this times out in 30 seconds (which is exactly kTimeout for thi The AddServer() was what was causing the stability issue, so I think it's fine. PS3, Line 1161: ASSERT_OK > What it itest::AddServer() returns other than IllegalState, not-the-leader I don't think so, since this operation should effectively be idempotent. PS3, Line 1187: LOG(INFO) << "Restarting tablet servers. New replica TS UUID: " << new_replica_uuid : << ", tablet data state: " : << tablet::TabletDataState_Name(superblock.tablet_data_state()) : << ", last-logged opid: " << superblock.tombstone_last_logged_opid(); > nit: would it make sense to move this after ASSERT_OPID_EQ() and before ASS I don't think so, because logging before a failure would make that failure easier to debug. http://gerrit.cloudera.org:8080/#/c/7961/3/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: PS3, Line 401: RETURN_NOT_OK(meta_->ReplaceSuperBlock(*superblock_)); > If not clearing the tombstone_last_logged_opid field in the superblock, wou Hmm. Let me make sure we have coverage for this case by adding a test. -- To view, visit http://gerrit.cloudera.org:8080/7961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbc9cecac701c24ebe05759adbbb1fbe2b140506 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
