Mike Percy has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7961/3/src/kudu/integration-tests/tablet_copy-itest.cc File src/kudu/integration-tests/tablet_copy-itest.cc: PS3, Line 1155: ASSERT_EVENTUALLY > That might be due to high load on the test machine. That assumes that we expect the timeouts in this test to actually max out the timeout. The kTimeout in this test is really there to cap how long a hang takes to fail the test. If this was production, I would agree with you that we would need to think carefully about the value. But in a test, the goal of the timeouts is different, and the only flakiness I saw in this test before wrapping this section in an ASSERT_EVENTUALLY was that AddServer() would immediately return with an error indicating that the server we contacted was no longer the leader. -- To view, visit http://gerrit.cloudera.org:8080/7961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbc9cecac701c24ebe05759adbbb1fbe2b140506 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
