Alexey Serbin has posted comments on this change. Change subject: tablet copy: Allow voting from crashed initial tablet copies ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7961/3/src/kudu/integration-tests/tablet_copy-itest.cc File src/kudu/integration-tests/tablet_copy-itest.cc: PS3, Line 1155: ASSERT_EVENTUALLY > That might be due to high load on the test machine. Just a clarification: I don't insist on updating the timeout for ASSERT_EVENTUALLY(), just wanted to understand this. If you think that's all right and 30 seconds should be also used for the overall timeout here -- that's fine with me. PS3, Line 1187: LOG(INFO) << "Restarting tablet servers. New replica TS UUID: " << new_replica_uuid : << ", tablet data state: " : << tablet::TabletDataState_Name(superblock.tablet_data_state()) : << ", last-logged opid: " << superblock.tombstone_last_logged_opid(); > I don't think so, because logging before a failure would make that failure OK, that sounds good to me. Just another nit: is this information is crucial for the successful run as well? If not, consider using SCOPED_TRACE() here instead of LOG(INFO). My point is: if the information is not needed in case of successful run of the test, I would prefer that information not to be output at all. It's not a crucial thing, just my 2 cents -- feel free to ignore, though. -- To view, visit http://gerrit.cloudera.org:8080/7961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbc9cecac701c24ebe05759adbbb1fbe2b140506 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
