Hao Hao has posted comments on this change. Change subject: KUDU-2119. Fix failure in encoding-test ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7967/3/src/kudu/cfile/encoding-test.cc File src/kudu/cfile/encoding-test.cc: Line 279: const uint kCount = r.Uniform(1000) + 1; Why need to '+1' here? Is it to ensure to add at least one element to the block? Can you add a comment for it? -- To view, visit http://gerrit.cloudera.org:8080/7967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic46d2a993235e560475d931c7b023eb5b4faf7c2 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
