Will Berkeley has posted comments on this change. Change subject: Add mustache template for /table ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8067/1/src/kudu/master/master-path-handlers.cc File src/kudu/master/master-path-handlers.cc: Line 336: state_json["percentage"] = tablets.size() == 0 ? "0.0" : StringPrintf("%.2f", percentage); > warning: the 'empty' method should be used to check for emptiness instead o Done Line 347: void MasterPathHandlers::HandleMasters(const Webserver::WebRequest& req, > warning: parameter 'req' is unused [misc-unused-parameters] Done Line 632: } else { > warning: do not use 'else' after 'return' [readability-else-after-return] Done -- To view, visit http://gerrit.cloudera.org:8080/8067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fe78e0701c1cd965650b101244212b5988f11fb Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
