Adar Dembo has posted comments on this change. Change subject: Add mustache template for /table ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/8067/5/src/kudu/master/master-path-handlers.cc File src/kudu/master/master-path-handlers.cc: Line 209: (*output)["error"] = Substitute("Master is not ready: ", l.first_failed_status().ToString()); The new Substitute calls in this function are missing a $0. Not captured by a unit test? http://gerrit.cloudera.org:8080/#/c/8067/5/src/kudu/master/master-path-handlers.h File src/kudu/master/master-path-handlers.h: PS5, Line 62: to Duplicate -- To view, visit http://gerrit.cloudera.org:8080/8067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fe78e0701c1cd965650b101244212b5988f11fb Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
