Todd Lipcon has posted comments on this change. Change subject: Add mustache template for /table ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8067/1/src/kudu/master/master-path-handlers.h File src/kudu/master/master-path-handlers.h: Line 63: // or an empty string if no http address is available for the tserver. nit: indent 'or' here so it looks like part of the above bullet point http://gerrit.cloudera.org:8080/#/c/8067/1/src/kudu/server/webui_util.cc File src/kudu/server/webui_util.cc: Line 44: col_json["name"] = col.name(); can you remind me how escaping works with the mustache template stuff? we do have to worry about it or are all substitutions always escaped when substituted into the template? -- To view, visit http://gerrit.cloudera.org:8080/8067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fe78e0701c1cd965650b101244212b5988f11fb Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
