Andrew Wong has posted comments on this change. Change subject: KUDU-501 Redirect to leader master web UI ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8068/2/src/kudu/master/master-path-handlers.cc File src/kudu/master/master-path-handlers.cc: PS2, Line 650: if (!s.ok()) { : s = s.CloneAndPrepend("unable to list masters"); : return s; : } RETURN_NOT_OK_PREPEND? http://gerrit.cloudera.org:8080/#/c/8068/2/src/kudu/master/master-path-handlers.h File src/kudu/master/master-path-handlers.h: PS2, Line 79: output nit: can you surround this in 's? At first glance it didn't read as a variable name. -- To view, visit http://gerrit.cloudera.org:8080/8068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If31543b7899976ec02704111e9e789035c44dfe1 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
