Will Berkeley has posted comments on this change. Change subject: KUDU-501 Redirect to leader master web UI ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8068/3/src/kudu/master/master-path-handlers.cc File src/kudu/master/master-path-handlers.cc: PS3, Line 221: // Track redirects to prevent a redirect loop. : string redirects_str; : int redirects = 0; : if (FindCopy(req.parsed_args, "redirects", &redirects_str)) { : if (!safe_strto32(redirects_str, &redirects)) { : redirects = 0; : } : } > Decompose this into a helper? Maybe: Done -- To view, visit http://gerrit.cloudera.org:8080/8068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If31543b7899976ec02704111e9e789035c44dfe1 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
