Todd Lipcon has posted comments on this change. Change subject: KUDU-501 Redirect to leader master web UI ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8068/2/src/kudu/master/master-path-handlers.cc File src/kudu/master/master-path-handlers.cc: Line 683: (*output)["leader_redirect"] = Substitute("$0/$1", leader_http_addr, path); I'm a little nervous of endless redirect loops. Do you think its' worth adding a parameter here like ?redir_attempt={i++} and in the case that you redirect more than 3 times, go to some page explaining the issue? Maybe this requires a lot of plumbing, though, in which case I guess we can go without. -- To view, visit http://gerrit.cloudera.org:8080/8068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If31543b7899976ec02704111e9e789035c44dfe1 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
