Todd Lipcon has posted comments on this change. Change subject: Add a simple benchmark to create 1M blocks and reopen LBM ......................................................................
Patch Set 1: (3 comments) > it'd be awesome to have somethings like this for actual tablets. likely out > of the scope of your work here though.. Isn't that sort of dense_node-itest? or you mean something which writes a bunch of rowsets and then times stuff like Tablet::Open? agreed it's out of scope (this was just a quick benchmark to motivate/measure the following patches in the series) http://gerrit.cloudera.org:8080/#/c/8006/1/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: Line 784: FLAGS_block_manager_preflush_control = "never"; > You set the flag to be 'never' to try to avoid the 'stable page writes' iss will do Line 793: ASSERT_OK_FAST(block->Finalize()); > By finalizing each block, you'll fill up one container at a time, which max You mind if I just mark this as a TODO / known deficiency of the test? This is meant to be more of a simple microbenchmark type thing to measure the performance of the blockmap insertions, and it served its purpose for that, so I don't want to spend a lot of time making it overly realistic. Line 799: LOG_TIMING(INFO, "reopening block manager") { > Maybe do the timing yourself and print out the average? actually I kind of like seeing the multiple runs, since sometimes you can see some "warmup" behavior if the first are slow. And having multiple runs makes it easier to run a t-test between a before/after, where the two means are not enough to determine significance. -- To view, visit http://gerrit.cloudera.org:8080/8006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cc3547db7d8389c4e89ff9d4d3043b5f2fbe878 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
