Todd Lipcon has posted comments on this change. Change subject: Add a simple benchmark to create 1M blocks and reopen LBM ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8006/2/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: PS2, Line 797: In particular, : // since we write such small blocks in this test, each block will likely : // begin on the same 4KB page as the prior one we wrote, and due to the : // "stable page writes" feature, each block will thus end up waiting : // on the writeback of the prior one. > That's only true when the filesystem block size is less than 4K though, rig Indeed that's right. I also am not sure why so many of our systems have 2K blocks. Perhaps it was a default in some earlier kernel and these guys have just been upgraded many times. -- To view, visit http://gerrit.cloudera.org:8080/8006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cc3547db7d8389c4e89ff9d4d3043b5f2fbe878 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
