Adar Dembo has posted comments on this change. Change subject: Fix tablet state metrics race ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8082/1/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: Line 1247: int TSTabletManager::NumNotInitializedTablets() { Can you borrow from an earlier approach where RefreshTabletStateCacheUnlocked: 1) Took the lock, and 2) Returned the specific metric asked for. That way each of these methods can be just one line. -- To view, visit http://gerrit.cloudera.org:8080/8082 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88585c04692a6dc168b3750be9888769240cf3f6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
