Todd Lipcon has posted comments on this change. Change subject: Fix tablet state metrics race ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8082/2/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: Line 1246: int TSTabletManager::NumNotInitializedTablets() { instead of all these separate functions, why not Bind directly to RefreshTabletStateCacheAndReturnCount? ie attach the metric to Bind(&TSTabletManager::RefreshTabletStateCacheAndReturnCount, Unretained(this), tablet::NOT_INITIALIZED) PS2, Line 1287: num_not_initialized would this code be simpler to just use an unordered_map<TabletStatePB, int> instead of separate fields for each? http://gerrit.cloudera.org:8080/#/c/8082/2/src/kudu/tserver/ts_tablet_manager.h File src/kudu/tserver/ts_tablet_manager.h: Line 313: // The caller should hold lock_. it doesn't seem like the caller holds lock -- To view, visit http://gerrit.cloudera.org:8080/8082 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88585c04692a6dc168b3750be9888769240cf3f6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
