Will Berkeley has posted comments on this change. Change subject: Fix tablet state metrics race ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8082/2/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: Line 1246: DataDirManager* dd_manager = fs_manager_->dd_manager(); > instead of all these separate functions, why not Bind directly to RefreshTa Done PS2, Line 1287: > would this code be simpler to just use an unordered_map<TabletStatePB, int> Done http://gerrit.cloudera.org:8080/#/c/8082/2/src/kudu/tserver/ts_tablet_manager.h File src/kudu/tserver/ts_tablet_manager.h: Line 313: typedef std::unordered_map<std::string, scoped_refptr<tablet::TabletReplica> > TabletMap; > it doesn't seem like the caller holds lock Done -- To view, visit http://gerrit.cloudera.org:8080/8082 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88585c04692a6dc168b3750be9888769240cf3f6 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
