Hello Dan Burkert, Mike Percy, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8089
to review the following change.
Change subject: catalog_manager: make ScopedTabletInfoCommitter generic
......................................................................
catalog_manager: make ScopedTabletInfoCommitter generic
I want to use it for TableInfo mutations, and to manage multiple read locks
too. So I've moved it to util/cow_object, created a read-only variant, and
templatized them for any CowObject.
Importantly, the default out-of-scope behavior is now Unlock(). Previously it
was Commit(), but I think Unlock() is less surprising.
Change-Id: I890db0fd18f773ab2253c49817def8162e04ad25
---
M src/kudu/master/catalog_manager-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/util/cow_object.h
6 files changed, 245 insertions(+), 198 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/8089/1
--
To view, visit http://gerrit.cloudera.org:8080/8089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I890db0fd18f773ab2253c49817def8162e04ad25
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
