Dan Burkert has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File src/kudu/util/cow_object.h: PS2, Line 240: A : // key must not be modified while its corresponding CowObject is held by the : // lock I don't understand this bit. The API statically guarantees that they key does not change, so why warn against it? Line 259: // CowGroupLock<string, Foo> l(CowGroupLock<string, Foo>::RELEASED); The CowGroupLock<string, Foo> thing is really ugly. C++ won't let you leave of the template params? If not, consider making this a proper enum class outside of CowGroupLock. -- To view, visit http://gerrit.cloudera.org:8080/8089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I890db0fd18f773ab2253c49817def8162e04ad25 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
