Alexey Serbin has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File src/kudu/util/cow_object.h: PS2, Line 240: The use of std::map forces callers to provide a key for each CowObject > Pointers would indeed provide a deterministic ordering, but they don't let Ah, that makes sense. For some reason it seems as an extra parameter to me. Would it make sense to use an array internally for that? Given the fact the number of locks would not be greater than a few, that would not make much impact on performance. -- To view, visit http://gerrit.cloudera.org:8080/8089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I890db0fd18f773ab2253c49817def8162e04ad25 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
