Alexey Serbin has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic ......................................................................
Patch Set 5: Code-Review+1 (4 comments) Spotted a few nits (sorry -- I didn't see them in prior passes). Otherwise LGTM. http://gerrit.cloudera.org:8080/#/c/8089/5/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS5, Line 3689: before after? http://gerrit.cloudera.org:8080/#/c/8089/5/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: PS5, Line 353: Style nit: if I'm not mistaken, it should be 4 spaces here instead of 2. PS5, Line 357: this-> Is it necessary? PS5, Line 361: this-> Is this necessary? -- To view, visit http://gerrit.cloudera.org:8080/8089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I890db0fd18f773ab2253c49817def8162e04ad25 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
