Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 )
Change subject: catalog_manager: make ScopedTabletInfoCommitter generic ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/8089/7/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/8089/7/src/kudu/master/catalog_manager.cc@2518 PS7, Line 2518: *modified_report.mutable_consensus_state() = cstate; Consider using std::move(cstate), although if you think it's too likely to break in subsequent revisions I'd be alright skipping it. http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h File src/kudu/util/cow_object.h: http://gerrit.cloudera.org:8080/#/c/8089/2/src/kudu/util/cow_object.h@259 PS2, Line 259: // > I'll convert LockMode into an enum class and reuse it in both CowLock and C Thanks, I think this is a big improvement. -- To view, visit http://gerrit.cloudera.org:8080/8089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I890db0fd18f773ab2253c49817def8162e04ad25 Gerrit-Change-Number: 8089 Gerrit-PatchSet: 7 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 21 Sep 2017 18:57:47 +0000 Gerrit-HasComments: Yes
