Adar Dembo has posted comments on this change. Change subject: catalog_manager: make ScopedTabletInfoCommitter generic ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/8089/5/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS5, Line 3689: before > after? Whoops, yes. http://gerrit.cloudera.org:8080/#/c/8089/5/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: PS5, Line 353: > Style nit: if I'm not mistaken, it should be 4 spaces here instead of 2. I was just copying what MetadataLock did. I'll fix both. PS5, Line 357: this-> > Is it necessary? If I don't use it, I get: ../../src/kudu/master/catalog_manager.h: In instantiation of ‘void kudu::master::MetadataGroupLock<MetadataClass>::AddMutableInfo(MetadataClass*) [with MetadataClass = kudu::master::TabletInfo]’: ../../src/kudu/master/catalog_manager.cc:3187:45: required from here ../../src/kudu/master/catalog_manager.h:355:21: error: ‘AddMutableObject’ was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive] AddMutableObject(info->id(), info->mutable_metadata()); ^ ../../src/kudu/master/catalog_manager.h:355:21: note: declarations in dependent base ‘kudu::CowGroupLock<std::__cxx11::basic_string<char>, kudu::master::PersistentTabletInfo>’ are not found by unqualified lookup ../../src/kudu/master/catalog_manager.h:355:21: note: use ‘this->AddMutableObject’ instead PS5, Line 361: this-> > Is this necessary? See above. -- To view, visit http://gerrit.cloudera.org:8080/8089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I890db0fd18f773ab2253c49817def8162e04ad25 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
