Will Berkeley has submitted this change and it was merged. Change subject: Fix tablet state metrics race ......................................................................
Fix tablet state metrics race 6fef9ca5c9d1dcf571795c514cb9fecc493d0714 added tablet state summary metrics by adding a struct with cached counts that was periodically refreshed by walking the tablet manager, but also added a race between reading the cached counts and refreshing them. This fixes the race by centralizing reading and writing the counts in the tablet manager and protecting them with the tablet manager's lock. Change-Id: I88585c04692a6dc168b3750be9888769240cf3f6 Reviewed-on: http://gerrit.cloudera.org:8080/8082 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> Reviewed-by: David Ribeiro Alves <[email protected]> --- M src/kudu/tserver/CMakeLists.txt M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h D src/kudu/tserver/ts_tablet_manager_metrics.cc D src/kudu/tserver/ts_tablet_manager_metrics.h 5 files changed, 106 insertions(+), 273 deletions(-) Approvals: David Ribeiro Alves: Looks good to me, approved Todd Lipcon: Looks good to me, but someone else must approve Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8082 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88585c04692a6dc168b3750be9888769240cf3f6 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]>
