Alexey Serbin has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8109/1/src/kudu/integration-tests/raft_config_change-itest.cc File src/kudu/integration-tests/raft_config_change-itest.cc: PS1, Line 124: When it : // sends a tablet report to the master with the new configuration excluding : // the removed tablet it will report an unknown leader in the new term. Is there a way to assert on this programmatically? PS1, Line 130: // Wait until the master re-adds the evicted replica and it is back up and : // running. : ASSERT_OK(WaitForServersToAgree(kTimeout, ts_map_, tablet_id, 1)); I might be missing something, but shouldn't it be under the ASSERT_EVENTUALLY() scope? -- To view, visit http://gerrit.cloudera.org:8080/8109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie882d05fc58e55836edc0235d14974e65125df6c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
