David Ribeiro Alves has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID ......................................................................
Patch Set 1: (2 comments) are you planning on adding a regular unit test or are you pretty confident on your itest? http://gerrit.cloudera.org:8080/#/c/8109/1/src/kudu/consensus/consensus_meta-test.cc File src/kudu/consensus/consensus_meta-test.cc: PS1, Line 286: cmeta->set_leader_uuid(""); mayber we should have something like cmeta->clear_leader_uuid() then? http://gerrit.cloudera.org:8080/#/c/8109/1/src/kudu/tserver/heartbeater.cc File src/kudu/tserver/heartbeater.cc: PS1, Line 384: // Inject latency for testing purposes. : if (PREDICT_FALSE(FLAGS_heartbeat_inject_latency_before_heartbeat_ms > 0)) { : TRACE("Injecting $0ms of latency due to --heartbeat_inject_latency_before_heartbeat_ms", : FLAGS_heartbeat_inject_latency_before_heartbeat_ms); : SleepFor(MonoDelta::FromMilliseconds(FLAGS_heartbeat_inject_latency_before_heartbeat_ms)); : } side note we should come up with some reasonable macros for these things -- To view, visit http://gerrit.cloudera.org:8080/8109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie882d05fc58e55836edc0235d14974e65125df6c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
