David Ribeiro Alves has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8109/1/src/kudu/consensus/consensus_meta-test.cc File src/kudu/consensus/consensus_meta-test.cc: PS1, Line 286: cmeta->set_leader_uuid(""); > We could do that but I would like to do it in a separate change. I filed KU sgtm, but would really like to see that happen since now we're using this as a special value and that's super clear to the caller. afraid we might get bitten again if we punt on it. -- To view, visit http://gerrit.cloudera.org:8080/8109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie882d05fc58e55836edc0235d14974e65125df6c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
