Alexey Serbin has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8109/1/src/kudu/integration-tests/raft_config_change-itest.cc File src/kudu/integration-tests/raft_config_change-itest.cc: PS1, Line 130: Substitute("$0", ms_delay))); : // Keep track of the followers. : if (cluster_->tablet_server(i)->uuid() != leader->uuid()) { > This checks that the last OpIds on all the replicas match. Thank you for the clarification. For some reason I thought it would be necessary to add that to restore the cluster to the original configuration to start next cycle of the operations under the ASSERT_EVENTUALLY scope, but apparently it's not necessary. http://gerrit.cloudera.org:8080/#/c/8109/3/src/kudu/integration-tests/raft_config_change-itest.cc File src/kudu/integration-tests/raft_config_change-itest.cc: PS3, Line 59: Steps followed in this test: Thank you for adding the high-level overview for the test scenario. PS3, Line 152: 1247 nit: 2147 ? -- To view, visit http://gerrit.cloudera.org:8080/8109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie882d05fc58e55836edc0235d14974e65125df6c Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
