Todd Lipcon has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8109/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS6, Line 2619: // To ensure consistent handling when modifying or sanitizing the cstate : // above, copy the whole report on the stack rather than const-casting. : ReportedTabletPB modified_report = report; : *modified_report.mutable_consensus_state() = cstate; isn't this regressing a performance optimization in that it is always now copying the whole report PB, whereas before it was only copying when necessary? worried this will harm scalability. -- To view, visit http://gerrit.cloudera.org:8080/8109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie882d05fc58e55836edc0235d14974e65125df6c Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
