Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8067 )

Change subject: Add mustache template for /table
......................................................................


Patch Set 11:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8067/11/src/kudu/master/master-path-handlers.h
File src/kudu/master/master-path-handlers.h:

http://gerrit.cloudera.org:8080/#/c/8067/11/src/kudu/master/master-path-handlers.h@62
PS11, Line 62: to
Looks like this duplicate 'to' snuck back in.


http://gerrit.cloudera.org:8080/#/c/8067/11/src/kudu/master/master-path-handlers.cc
File src/kudu/master/master-path-handlers.cc:

http://gerrit.cloudera.org:8080/#/c/8067/11/src/kudu/master/master-path-handlers.cc@210
PS11, Line 210:     (*output)["error"] = Substitute("Master is not ready: ", 
l.first_failed_status().ToString());
And the Substitute() calls lost their $0?



--
To view, visit http://gerrit.cloudera.org:8080/8067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fe78e0701c1cd965650b101244212b5988f11fb
Gerrit-Change-Number: 8067
Gerrit-PatchSet: 11
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-Comment-Date: Fri, 22 Sep 2017 17:01:31 +0000
Gerrit-HasComments: Yes

Reply via email to