Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8067 )
Change subject: Add mustache template for /table ...................................................................... Patch Set 8: Code-Review+1 (3 comments) A couple nits but generally LGTM (looked in detail at the escaping in particular) http://gerrit.cloudera.org:8080/#/c/8067/8/src/kudu/master/master-path-handlers.cc File src/kudu/master/master-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/8067/8/src/kudu/master/master-path-handlers.cc@240 PS8, Line 240: (*output)["state_msg"] = l.data().pb.state_msg(); should this just be 'state_msg'? http://gerrit.cloudera.org:8080/#/c/8067/8/src/kudu/master/master-path-handlers.cc@280 PS8, Line 280: link_pair.first nit: you could std::move this and same on the next line, rght? http://gerrit.cloudera.org:8080/#/c/8067/8/src/kudu/master/master-path-handlers.cc@603 PS8, Line 603: return std::make_pair(text, target); worth std::moveing text, target? -- To view, visit http://gerrit.cloudera.org:8080/8067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fe78e0701c1cd965650b101244212b5988f11fb Gerrit-Change-Number: 8067 Gerrit-PatchSet: 8 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 21 Sep 2017 17:38:03 +0000 Gerrit-HasComments: Yes
