Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8067 )
Change subject: Add mustache template for /table ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/8067/5/src/kudu/master/master-path-handlers.cc File src/kudu/master/master-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/8067/5/src/kudu/master/master-path-handlers.cc@209 PS5, Line 209: (*output)["error"] = Substitute("Master is not ready: ", l.first_failed_status().ToString()); > You missed a couple other Substitute() calls below. Done http://gerrit.cloudera.org:8080/#/c/8067/8/src/kudu/master/master-path-handlers.cc File src/kudu/master/master-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/8067/8/src/kudu/master/master-path-handlers.cc@240 PS8, Line 240: } > should this just be 'state_msg'? I don't understand. AFAICT state_msg() is never set in the current code. If state = "foo" and state_msg = "bar" then the old formatting would display "foobar". The new formatting would display "foo (bar)", so the change here is future-proofing. http://gerrit.cloudera.org:8080/#/c/8067/8/src/kudu/master/master-path-handlers.cc@280 PS8, Line 280: = link_pair.sec > nit: you could std::move this and same on the next line, rght? Done http://gerrit.cloudera.org:8080/#/c/8067/8/src/kudu/master/master-path-handlers.cc@603 PS8, Line 603: } > worth std::moveing text, target? Done -- To view, visit http://gerrit.cloudera.org:8080/8067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fe78e0701c1cd965650b101244212b5988f11fb Gerrit-Change-Number: 8067 Gerrit-PatchSet: 5 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 21 Sep 2017 17:59:29 +0000 Gerrit-HasComments: Yes
