Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 )
Change subject: WIP: Pull StatusOr<T> and related tests from protobuf ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8127/1/src/kudu/util/statusor.h File src/kudu/util/statusor.h: http://gerrit.cloudera.org:8080/#/c/8127/1/src/kudu/util/statusor.h@94 PS1, Line 94: class StatusOr { Going to bike shed a bit (sorry). I think the name is kind of unwieldy, and I'm hoping this is going to be a frequently used type. Off the top of my head, I think these languages have better names, ranked in terms of my preference: Result (Rust) Try (Scala) expected (C++ proposal n4015) Either (Haskell) I think Result and Try in particular are better than StatusOr. -- To view, visit http://gerrit.cloudera.org:8080/8127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2d86a3769da733456956fb892de6d679a011a63 Gerrit-Change-Number: 8127 Gerrit-PatchSet: 1 Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 22 Sep 2017 19:46:03 +0000 Gerrit-HasComments: Yes
